Templates
Review against the Jira ticket
Finds the ticket in the branch name or title and checks the change against its acceptance criteria.
- Kind: Code review
- Category: Integrations
- Added to new projects: No
- Needs: jira
Checklists, in order
- Correctness: Logic errors, missing awaits, off-by-one, empty and null cases, races.
- What else it can break: Callers, exports and configs elsewhere in the repo that the change didn't update.
- Security: Secrets, injection, unchecked input, weaker auth, unsafe workflow changes.
- Tests: Changed behaviour without a test, or a test that can never fail.
- Docs: A change users can see with no docs or README update.
- Changelog and changeset: A published package changed with no changeset or changelog entry, or with the wrong version bump.
- The repo's standards: Naming, file layout and patterns the repo already uses, and helpers it already has.
Last updated on