Axon Shaft docs
Templates

Expo or React Native app

For Expo and React Native apps. Native and over-the-air update mistakes come right after correctness, since they cost a store release, and the UI checks run only on UI files.

  • Kind: Code review
  • Category: By project type
  • Added to new projects: No

Checklists, in order

  1. Correctness: Logic errors, missing awaits, off-by-one, empty and null cases, races.
  2. Native and store: Permissions and privacy manifest entries, config plugins, native changes with no runtime version bump and code that handles only one platform.
  3. What else it can break: Callers, exports and configs elsewhere in the repo that the change didn't update.
  4. Security: Secrets, injection, unchecked input, weaker auth, unsafe workflow changes.
  5. React patterns: Hook rules, effect dependencies, list keys, state in the wrong place and needless re-renders.
  6. Accessibility: Labels, roles and alt text, keyboard and focus, touch target size and accessibility labels in React Native.
  7. Translations: Hard-coded text people see in a repo that has translations, keys missing from a locale and dates or numbers formatted by hand.
  8. Theme and design tokens: Raw colours, spacing and font sizes where the repo has tokens, dark mode left out and breaks from the repo's theming guide.
  9. Performance: N+1 queries, awaits in loops, unbounded queries or lists and slow work in hot paths and renders.
  10. Tests: Changed behaviour without a test, or a test that can never fail.
  11. Dependencies: Added, removed and upgraded packages, major bumps, packages in the wrong dependency list and packages nothing imports.
  12. Known vulnerabilities: Added or changed package versions with a published security advisory.
  13. Secrets: Keys, tokens and private keys in added lines.

Last updated on